On Mon, Jan 04, 2016 at 08:18:59AM -0500, Oleg Drokin wrote:
>
> On Jan 4, 2016, at 4:55 AM, Dan Carpenter wrote:
>
> > On Sun, Jan 03, 2016 at 12:05:35PM -0500, green@xxxxxxxxxxxxxx wrote:
> >> diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h b/drivers/staging/lustre/lustre/include/lustre_lib.h
> >> index 428469f..7daf954 100644
> >> --- a/drivers/staging/lustre/lustre/include/lustre_lib.h
> >> +++ b/drivers/staging/lustre/lustre/include/lustre_lib.h
> >> @@ -365,10 +365,10 @@ static inline void obd_ioctl_freedata(char *buf, int len)
> >> /* OBD_IOC_LLOG_CATINFO is deprecated */
> >> #define OBD_IOC_LLOG_CATINFO _IOWR('f', 196, OBD_IOC_DATA_TYPE)
> >>
> >> -#define ECHO_IOC_GET_STRIPE _IOWR('f', 200, OBD_IOC_DATA_TYPE)
> >> -#define ECHO_IOC_SET_STRIPE _IOWR('f', 201, OBD_IOC_DATA_TYPE)
> >> -#define ECHO_IOC_ENQUEUE _IOWR('f', 202, OBD_IOC_DATA_TYPE)
> >> -#define ECHO_IOC_CANCEL _IOWR('f', 203, OBD_IOC_DATA_TYPE)
> >> +/* #define ECHO_IOC_GET_STRIPE _IOWR('f', 200, OBD_IOC_DATA_TYPE) */
> >> +/* #define ECHO_IOC_SET_STRIPE _IOWR('f', 201, OBD_IOC_DATA_TYPE) */
> >> +/* #define ECHO_IOC_ENQUEUE _IOWR('f', 202, OBD_IOC_DATA_TYPE) */
> >> +/* #define ECHO_IOC_CANCEL _IOWR('f', 203, OBD_IOC_DATA_TYPE) */
> > Please delete these completely in a follow on patch.
>
> Is not there some value in retaining these at least for some time to ensure they
> are not reused right away?
Ah, ok. That makes sense...
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
