On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > covici@xxxxxxxxxxxxxx, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for serialio.c. That > however makes me realize that the culprit is actually > f79b0d9 (which actually doesn't make much sense since linux/serial.h is > getting included a couple of lines above...). CC the guilty. Also we have a Fixes tag. Please use it. > > I don't know what this "use <linux/serial.h> instead <asm/serial.h>" > warning is about, but *no* header in include/ includes asm/serial.h, so > there is no way to get the SERIAL_PORT_DFNS definition just by including > linux/serial.h, we really need asm/serial.h, just like 8250*.c do. > > So we really need serialio.c to include linux/serial_core.h then > asm/serial.h, as my patch does. Ah... Ok. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
