On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote: > On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee > <sudipm.mukherjee@xxxxxxxxx> wrote: > > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > >> Split comment in order to fit into 80 characters per line. > >> Found by checkpatch.pl > >> > >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@xxxxxxxxx> > >> --- > > > > Instead of multiline maybe this is better: > > > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > > index 79ac192..3525919 100644 > > --- a/drivers/staging/panel/panel.c > > +++ b/drivers/staging/panel/panel.c > > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void) > > lcd_send_serial(0x5F); /* R/W=W, RS=1 */ > > lcd_send_serial(' ' & 0x0F); > > lcd_send_serial((' ' >> 4) & 0x0F); > > - usleep_range(40, 100); /* the shortest data takes at least 40 us */ > > + /* the shortest data takes at least 40 us */ > > + usleep_range(40, 100); > > } > > spin_unlock_irq(&pprt_lock); > > It's already been done by Bijosh Thykkoottathil: > https://lkml.org/lkml/2015/12/18/681 But I think not yet accepted by Greg. And his commit message doesnot mention what coding style errors he has fixed. Usually Greg will not accept them. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel