Hi Glen, On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee <glen.lee@xxxxxxxxx> wrote: > wilc_sdio_init return always 1. It is needless, so just remove it and it's > related codes also. > > Signed-off-by: Glen Lee <glen.lee@xxxxxxxxx> > --- > drivers/staging/wilc1000/wilc_sdio.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c > index e961b50..caad876 100644 > --- a/drivers/staging/wilc1000/wilc_sdio.c > +++ b/drivers/staging/wilc1000/wilc_sdio.c > @@ -185,11 +185,6 @@ static void wilc_sdio_disable_interrupt(struct wilc *dev) > dev_info(&func->dev, "wilc_sdio_disable_interrupt OUT\n"); > } > > -static int wilc_sdio_init(void) > -{ > - return 1; > -} > - > /******************************************** > * > * Function 0 > @@ -611,13 +606,6 @@ static int sdio_init(struct wilc *wilc) > > g_sdio.irq_gpio = (wilc->dev_irq_num); > > - if (!wilc_sdio_init()) { > - dev_err(&func->dev, "Failed io init bus...\n"); > - return 0; > - } else { > - return 0; > - } > - This isn't equivalent code as both arms of the if statement eventually call return 0. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel