On Mon, 2015-12-14 at 19:11 -0800, Greg KH wrote:
> On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
> > From: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
> >
> > Use the local uapi headers to keep in sync with "recently" added #define's
> > (e.g. VSS_OP_REGISTER1).
> >
> > Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb
>
> Please use the "correct" way of listing this:
> 3eb2094c59e8 ("Adding makefile for tools/hv")
>
> And as this is an old kernel, shouldn't it go into stable releases?
Yes it should. I'll resubmit with Cc: stable and correct the Fixes
line.
> Or
> does that mean that no one really ever runs into this issue?
>
> > Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > ---
> > tools/hv/Makefile | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> > index a8ab795..a8c4644 100644
> > --- a/tools/hv/Makefile
> > +++ b/tools/hv/Makefile
> > @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
> > WARNINGS = -Wall -Wextra
> > CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
> >
> > +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include
>
> Why do you need ../../include also?
Because include/uapi/linux/stddef.h includes linux/compiler.h, so
omitting ../../include yields:
gcc -Wall -Wextra -g -lpthread -D__EXPORTED_HEADERS__ -I../../include/uapi -o hv_kvp_daemon hv_kvp_daemon.c
In file included from ../../include/uapi/linux/posix_types.h:4:0,
from ../../include/uapi/linux/types.h:13,
from ../../include/uapi/linux/uuid.h:24,
from ../../include/uapi/linux/hyperv.h:28,
from hv_kvp_daemon.c:36:
../../include/uapi/linux/stddef.h:1:28: fatal error: linux/compiler.h: No such file or directory
#include <linux/compiler.h>
^
-Kamal
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
