On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki <jpage.lkml@xxxxxxxxx> wrote: > > Patch contains the spacing fixes that led to checkpatch.pl warnings. > > Signed-off-by: Sanidhya Solanki <jpage.lkml@xxxxxxxxx> > --- > drivers/staging/dgnc/dgnc_cls.c | 4 +- > drivers/staging/dgnc/dgnc_driver.h | 8 -- > drivers/staging/dgnc/dgnc_neo.c | 235 > ++++++++++++++++++++++++------------- > drivers/staging/dgnc/dgnc_neo.h | 22 ++-- > drivers/staging/dgnc/dgnc_pci.h | 1 - > drivers/staging/dgnc/dgnc_sysfs.c | 18 ++- > drivers/staging/dgnc/dgnc_tty.c | 46 +++++--- > drivers/staging/dgnc/digi.h | 32 ++--- 8 files changed, 223 > insertions(+), 143 deletions(-) > Hi Sanidhya, Just to help you out since you're struggling some. Subject line should be something like "Fix checkpatch warnings". Better yet would be a subject specifying what you fixed to silence checkpatch warnings. For example, "Fixed comments formatting" or "Removed unnecessary spaces" And the commit message should not be vague like "Patch contains the spacing fixes that led to checkpatch.pl warnings." You should write what you did to fix the warnings. For example: Fixed checkpatch warning *write warning here* by correcting *whatever change you did* Regards, Amitoj _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
