Hi Simon, Am Mittwoch, 9. Dezember 2015, 08:14:06 schrieb Simon Guinot: > This patch fixes a couple of checkpatch warnings about block comments. > > Signed-off-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx> > --- > drivers/staging/nvec/nvec.c | 6 ++++-- > drivers/staging/nvec/nvec_power.c | 14 +++++++++----- > 2 files changed, 13 insertions(+), 7 deletions(-) there was a similar patch from Sakshi Bansal [1] (cc'd) a while ago which also fixed a few other stuff. But it had a small bug inside so it wasn't applied. Up to now, Sakshi didn't sent a corrected version yet, but I want to give him some more time - *ping Sakshi ping* ! If there is no reply, I will send a corrected version of his patch with proper credits. Thanks! Marc [1] https://lkml.org/lkml/2015/10/14/516 > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 802c9597d421..cb0927ddd78f 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -508,8 +508,10 @@ static void nvec_rx_completed(struct nvec_chip *nvec) > > spin_lock(&nvec->rx_lock); > > - /* add the received data to the work list > - and move the ring buffer pointer to the next entry */ > + /* > + * Add the received data to the work list and move the ring buffer > + * pointer to the next entry. > + */ > list_add_tail(&nvec->rx->node, &nvec->rx_data); > > spin_unlock(&nvec->rx_lock); > diff --git a/drivers/staging/nvec/nvec_power.c > b/drivers/staging/nvec/nvec_power.c index 04a7402ae2df..b4a0545e8806 100644 > --- a/drivers/staging/nvec/nvec_power.c > +++ b/drivers/staging/nvec/nvec_power.c > @@ -207,8 +207,10 @@ static int nvec_power_bat_notifier(struct > notifier_block *nb, case TYPE: > memcpy(power->bat_type, &res->plc, res->length - 2); > power->bat_type[res->length - 2] = '\0'; > - /* this differs a little from the spec > - fill in more if you find some */ > + /* > + * This differs a little from the spec fill in more if you find > + * some. > + */ > if (!strncmp(power->bat_type, "Li", 30)) > power->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_LION; > else > @@ -356,12 +358,14 @@ static void nvec_power_poll(struct work_struct *work) > if (counter >= ARRAY_SIZE(bat_iter)) > counter = 0; > > -/* AC status via sys req */ > + /* AC status via sys req */ > nvec_write_async(power->nvec, buf, 2); > msleep(100); > > -/* select a battery request function via round robin > - doing it all at once seems to overload the power supply */ > + /* > + * Select a battery request function via round robin doing it all at > + * once seems to overload the power supply. > + */ > buf[0] = NVEC_BAT; > buf[1] = bat_iter[counter++]; > nvec_write_async(power->nvec, buf, 2);
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
