On 12 December 2015 at 15:41, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > > This patch does the following: >> > > * changed the complicated if statements to simple case statements >> > > * in case of E_DEFAULT, no need to return error as ERESTART, >> > > because this is the user asked for. Hence function should return success. >> > > * ret variable is 0 always, hence removed it. >> > > * removed one ternary operator, as it was always returning the status value only, >> > > and hence removed the status variable too >> > >> > That becomes 4 different changes. Please break them into separate >> > patches. >> >> It's cleaning up one function so you could argue that it's just one >> thing. > > Then maybe that should have been mentioned in the commit message along > with mentioning point wise the different changes made. > That is already mentioned in subject line of patch, which will be the part of commit message. Regrads, Saurabh _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
