>From c07c57f3e045865b0acae498c631189f24aeda0b Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki <jpage.lkml@xxxxxxxxx> Date: Thu, 10 Dec 2015 21:13:10 -0500 Subject: [PATCH] staging: gdm72xx: Code cleanups Code cleanups as per the TODO file. Signed-off-by: Sanidhya Solanki <jpage.lkml@xxxxxxxxx> --- drivers/staging/gdm72xx/gdm_qos.c | 54 +++++++++++++++---------------- drivers/staging/gdm72xx/gdm_sdio.c | 4 +-- drivers/staging/gdm72xx/gdm_usb.c | 3 +- drivers/staging/gdm72xx/gdm_usb.h | 4 +-- drivers/staging/gdm72xx/gdm_wimax.c | 18 +++++------ drivers/staging/gdm72xx/hci.h | 11 +++---- drivers/staging/gdm72xx/netlink_k.c | 8 ++--- drivers/staging/gdm72xx/sdio_boot.c | 2 +- drivers/staging/gdm72xx/usb_boot.c | 10 +++--- drivers/staging/gdm72xx/usb_ids.h | 64 ++++++++++++++++++------------------- 10 files changed, 88 insertions(+), 90 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index 81feffa..c03204b 100644 --- a/drivers/staging/gdm72xx/gdm_qos.c +++ b/drivers/staging/gdm72xx/gdm_qos.c @@ -101,7 +101,7 @@ void gdm_qos_init(void *nic_ptr) } qcb->qos_list_cnt = 0; - qcb->qos_null_idx = QOS_MAX-1; + qcb->qos_null_idx = QOS_MAX - 1; qcb->qos_limit_size = 255; spin_lock_init(&qcb->qos_lock); @@ -128,7 +128,7 @@ void gdm_qos_release_list(void *nic_ptr) } qcb->qos_list_cnt = 0; - qcb->qos_null_idx = QOS_MAX-1; + qcb->qos_null_idx = QOS_MAX - 1; for (i = 0; i < QOS_MAX; i++) { list_for_each_entry_safe(entry, n, &qcb->qos_list[i], list) { @@ -143,18 +143,18 @@ static int chk_ipv4_rule(struct gdm_wimax_csr_s *csr, u8 *stream, u8 *port) { int i; - if (csr->classifier_rule_en&IPTYPEOFSERVICE) { + if (csr->classifier_rule_en & IPTYPEOFSERVICE) { if (((stream[1] & csr->ip2s_mask) < csr->ip2s_lo) || ((stream[1] & csr->ip2s_mask) > csr->ip2s_hi)) return 1; } - if (csr->classifier_rule_en&PROTOCOL) { + if (csr->classifier_rule_en & PROTOCOL) { if (stream[9] != csr->protocol) return 1; } - if (csr->classifier_rule_en&IPMASKEDSRCADDRESS) { + if (csr->classifier_rule_en & IPMASKEDSRCADDRESS) { for (i = 0; i < 4; i++) { if ((stream[12 + i] & csr->ipsrc_addrmask[i]) != (csr->ipsrc_addr[i] & csr->ipsrc_addrmask[i])) @@ -162,7 +162,7 @@ static int chk_ipv4_rule(struct gdm_wimax_csr_s *csr, u8 *stream, u8 *port) } } - if (csr->classifier_rule_en&IPMASKEDDSTADDRESS) { + if (csr->classifier_rule_en & IPMASKEDDSTADDRESS) { for (i = 0; i < 4; i++) { if ((stream[16 + i] & csr->ipdst_addrmask[i]) != (csr->ipdst_addr[i] & csr->ipdst_addrmask[i])) @@ -170,14 +170,14 @@ static int chk_ipv4_rule(struct gdm_wimax_csr_s *csr, u8 *stream, u8 *port) } } - if (csr->classifier_rule_en&PROTOCOLSRCPORTRANGE) { - i = ((port[0]<<8)&0xff00)+port[1]; + if (csr->classifier_rule_en & PROTOCOLSRCPORTRANGE) { + i = ((port[0] << 8) & 0xff00) + port[1]; if ((i < csr->srcport_lo) || (i > csr->srcport_hi)) return 1; } - if (csr->classifier_rule_en&PROTOCOLDSTPORTRANGE) { - i = ((port[2]<<8)&0xff00)+port[3]; + if (csr->classifier_rule_en & PROTOCOLDSTPORTRANGE) { + i = ((port[2] << 8) & 0xff00) + port[3]; if ((i < csr->dstport_lo) || (i > csr->dstport_hi)) return 1; } @@ -193,7 +193,7 @@ static int get_qos_index(struct nic *nic, u8 *iph, u8 *tcpudph) if (!iph || !tcpudph) return -1; - ip_ver = (iph[0]>>4)&0xf; + ip_ver = (iph[0] >> 4) & 0xf; if (ip_ver != 4) return -1; @@ -261,7 +261,7 @@ int gdm_qos_send_hci_pkt(struct sk_buff *skb, struct net_device *dev) struct list_head send_list; int ret = 0; - tcph = (struct tcphdr *)iph + iph->ihl*4; + tcph = (struct tcphdr *)iph + iph->ihl * 4; if (ethh->h_proto == cpu_to_be16(ETH_P_IP)) { if (qcb->qos_list_cnt && !qos_free_list.cnt) { @@ -342,17 +342,17 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) if (sub_cmd_evt == QOS_REPORT) { spin_lock_irqsave(&qcb->qos_lock, flags); for (i = 0; i < qcb->qos_list_cnt; i++) { - sfid = ((buf[(i*5)+6]<<24)&0xff000000); - sfid += ((buf[(i*5)+7]<<16)&0xff0000); - sfid += ((buf[(i*5)+8]<<8)&0xff00); - sfid += (buf[(i*5)+9]); + sfid = ((buf[(i * 5) + 6] << 24) & 0xff000000); + sfid += ((buf[(i * 5) + 7] << 16) & 0xff0000); + sfid += ((buf[(i * 5) + 8] << 8) & 0xff00); + sfid += (buf[(i * 5) + 9]); index = get_csr(qcb, sfid, 0); if (index == -1) { spin_unlock_irqrestore(&qcb->qos_lock, flags); netdev_err(nic->netdev, "QoS ERROR: No SF\n"); return; } - qcb->csr[index].qos_buf_count = buf[(i*5)+10]; + qcb->csr[index].qos_buf_count = buf[(i * 5) + 10]; } extract_qos_list(nic, &send_list); @@ -363,9 +363,9 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) /* sub_cmd_evt == QOS_ADD || sub_cmd_evt == QOS_CHANG_DEL */ pos = 6; - sfid = ((buf[pos++]<<24)&0xff000000); - sfid += ((buf[pos++]<<16)&0xff0000); - sfid += ((buf[pos++]<<8)&0xff00); + sfid = ((buf[pos++] << 24) & 0xff000000); + sfid += ((buf[pos++] << 16) & 0xff0000); + sfid += ((buf[pos++] << 8) & 0xff00); sfid += (buf[pos++]); index = get_csr(qcb, sfid, 1); @@ -382,7 +382,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) spin_lock_irqsave(&qcb->qos_lock, flags); qcb->csr[index].sfid = sfid; - qcb->csr[index].classifier_rule_en = ((buf[pos++]<<8)&0xff00); + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); qcb->csr[index].classifier_rule_en += buf[pos++]; if (qcb->csr[index].classifier_rule_en == 0) qcb->qos_null_idx = index; @@ -406,16 +406,16 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) qcb->csr[index].ipdst_addr[1] = buf[pos++]; qcb->csr[index].ipdst_addr[2] = buf[pos++]; qcb->csr[index].ipdst_addr[3] = buf[pos++]; - qcb->csr[index].srcport_lo = ((buf[pos++]<<8)&0xff00); + qcb->csr[index].srcport_lo = ((buf[pos++] << 8) & 0xff00); qcb->csr[index].srcport_lo += buf[pos++]; - qcb->csr[index].srcport_hi = ((buf[pos++]<<8)&0xff00); + qcb->csr[index].srcport_hi = ((buf[pos++] << 8) & 0xff00); qcb->csr[index].srcport_hi += buf[pos++]; - qcb->csr[index].dstport_lo = ((buf[pos++]<<8)&0xff00); + qcb->csr[index].dstport_lo = ((buf[pos++] << 8) & 0xff00); qcb->csr[index].dstport_lo += buf[pos++]; - qcb->csr[index].dstport_hi = ((buf[pos++]<<8)&0xff00); + qcb->csr[index].dstport_hi = ((buf[pos++] << 8) & 0xff00); qcb->csr[index].dstport_hi += buf[pos++]; - qcb->qos_limit_size = 254/qcb->qos_list_cnt; + qcb->qos_limit_size = 254 / qcb->qos_list_cnt; spin_unlock_irqrestore(&qcb->qos_lock, flags); } else if (sub_cmd_evt == QOS_CHANGE_DEL) { netdev_dbg(nic->netdev, "QOS_CHANGE_DEL SFID = 0x%x, index=%d\n", @@ -426,7 +426,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) spin_lock_irqsave(&qcb->qos_lock, flags); qcb->csr[index].enabled = false; qcb->qos_list_cnt--; - qcb->qos_limit_size = 254/qcb->qos_list_cnt; + qcb->qos_limit_size = 254 / qcb->qos_list_cnt; list_for_each_entry_safe(entry, n, &qcb->qos_list[index], list) { diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c index b0521da..3315f0c 100644 --- a/drivers/staging/gdm72xx/gdm_sdio.c +++ b/drivers/staging/gdm72xx/gdm_sdio.c @@ -33,10 +33,10 @@ #define SDU_TX_BUF_SIZE 2048 #define TX_BUF_SIZE 2048 #define TX_CHUNK_SIZE (2048 - TYPE_A_HEADER_SIZE) -#define RX_BUF_SIZE (25*1024) +#define RX_BUF_SIZE (25 * 1024) #define TX_HZ 2000 -#define TX_INTERVAL (1000000/TX_HZ) +#define TX_INTERVAL (1000000 / TX_HZ) static struct sdio_tx *alloc_tx_struct(struct tx_cxt *tx) { diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index 16e497d..f81129d 100644 --- a/drivers/staging/gdm72xx/gdm_usb.c +++ b/drivers/staging/gdm72xx/gdm_usb.c @@ -29,7 +29,7 @@ MODULE_DEVICE_TABLE(usb, id_table); #define TX_BUF_SIZE 2048 #if defined(CONFIG_WIMAX_GDM72XX_WIMAX2) -#define RX_BUF_SIZE (128*1024) /* For packet aggregation */ +#define RX_BUF_SIZE (128 * 1024) /* For packet aggregation */ #else #define RX_BUF_SIZE 2048 #endif @@ -544,7 +544,6 @@ static int gdm_usb_probe(struct usb_interface *intf, idVendor, idProduct); dev_info(&intf->dev, "GCT WiMax driver version %s\n", DRIVER_VERSION); - if (idProduct == EMERGENCY_PID) { ret = usb_emergency(usbdev); goto out; diff --git a/drivers/staging/gdm72xx/gdm_usb.h b/drivers/staging/gdm72xx/gdm_usb.h index 8e58a25..2a14e62 100644 --- a/drivers/staging/gdm72xx/gdm_usb.h +++ b/drivers/staging/gdm72xx/gdm_usb.h @@ -18,8 +18,8 @@ #include <linux/usb.h> #include <linux/list.h> -#define B_DIFF_DL_DRV (1 << 4) -#define B_DOWNLOAD (1 << 5) +#define B_DIFF_DL_DRV BIT(4) +#define B_DOWNLOAD BIT(5) #define MAX_NR_SDU_BUF 64 struct usb_tx { diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index d9ddced..86da289 100644 --- a/drivers/staging/gdm72xx/gdm_wimax.c +++ b/drivers/staging/gdm72xx/gdm_wimax.c @@ -116,8 +116,8 @@ static void gdm_wimax_event_rcv(struct net_device *dev, u16 type, void *msg, struct nic *nic = netdev_priv(dev); u8 *buf = msg; - u16 hci_cmd = (buf[0]<<8) | buf[1]; - u16 hci_len = (buf[2]<<8) | buf[3]; + u16 hci_cmd = (buf[0] << 8) | buf[1]; + u16 hci_len = (buf[2] << 8) | buf[3]; netdev_dbg(dev, "H=>D: 0x%04x(%d)\n", hci_cmd, hci_len); @@ -198,8 +198,8 @@ static int gdm_wimax_event_send(struct net_device *dev, char *buf, int size) struct evt_entry *e; unsigned long flags; - u16 hci_cmd = ((u8)buf[0]<<8) | (u8)buf[1]; - u16 hci_len = ((u8)buf[2]<<8) | (u8)buf[3]; + u16 hci_cmd = ((u8)buf[0] << 8) | (u8)buf[1]; + u16 hci_len = ((u8)buf[2] << 8) | (u8)buf[3]; netdev_dbg(dev, "D=>H: 0x%04x(%d)\n", hci_cmd, hci_len); @@ -333,7 +333,7 @@ static void gdm_wimax_ind_if_updown(struct net_device *dev, int if_up) hci->length = cpu_to_be16(sizeof(up_down)); hci->data[0] = up_down; - gdm_wimax_event_send(dev, (char *)hci, HCI_HEADER_SIZE+sizeof(up_down)); + gdm_wimax_event_send(dev, (char *)hci, HCI_HEADER_SIZE + sizeof(up_down)); } static int gdm_wimax_open(struct net_device *dev) @@ -513,7 +513,7 @@ static void gdm_wimax_prepare_device(struct net_device *dev) hci->cmd_evt = cpu_to_be16(WIMAX_GET_INFO); hci->data[len++] = TLV_T(T_MAC_ADDRESS); hci->length = cpu_to_be16(len); - gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len); + gdm_wimax_send(nic, hci, HCI_HEADER_SIZE + len); val = T_CAPABILITY_WIMAX | T_CAPABILITY_MULTI_CS; #if defined(CONFIG_WIMAX_GDM72XX_QOS) @@ -532,7 +532,7 @@ static void gdm_wimax_prepare_device(struct net_device *dev) memcpy(&hci->data[len], &val_be32, TLV_L(T_CAPABILITY)); len += TLV_L(T_CAPABILITY); hci->length = cpu_to_be16(len); - gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len); + gdm_wimax_send(nic, hci, HCI_HEADER_SIZE + len); netdev_info(dev, "GDM WiMax Set CAPABILITY: 0x%08X\n", val); } @@ -545,10 +545,10 @@ static int gdm_wimax_hci_get_tlv(u8 *buf, u8 *T, u16 *L, u8 **V) *T = buf[0]; if (buf[1] == 0x82) { *L = be16_to_cpu(__U82U16(&buf[2])); - next_pos = 1/*type*/+3/*len*/; + next_pos = 1/*type*/ + 3/*len*/; } else { *L = buf[1]; - next_pos = 1/*type*/+1/*len*/; + next_pos = 1/*type*/ + 1/*len*/; } *V = &buf[next_pos]; diff --git a/drivers/staging/gdm72xx/hci.h b/drivers/staging/gdm72xx/hci.h index 10a6bfa..1af9146 100644 --- a/drivers/staging/gdm72xx/hci.h +++ b/drivers/staging/gdm72xx/hci.h @@ -17,7 +17,7 @@ #define HCI_HEADER_SIZE 4 #define HCI_VALUE_OFFS (HCI_HEADER_SIZE) #define HCI_MAX_PACKET 2048 -#define HCI_MAX_PARAM (HCI_MAX_PACKET-HCI_HEADER_SIZE) +#define HCI_MAX_PARAM (HCI_MAX_PACKET - HCI_HEADER_SIZE) #define HCI_MAX_TLV 32 /* CMD-EVT */ @@ -159,7 +159,6 @@ #define T_TX_POWER (0x6a | (1 << 16)) #define T_CUR_FREQ (0x7f | (4 << 16)) - /* WIMAX */ #define T_MAX_SUBSCRIPTION (0xa1 | (1 << 16)) #define T_MAX_SF (0xa2 | (1 << 16)) @@ -199,10 +198,10 @@ #define T_DUPLEX_MODE (0xdb | (4 << 16)) /* T_CAPABILITY */ -#define T_CAPABILITY_MULTI_CS (1 << 0) -#define T_CAPABILITY_WIMAX (1 << 1) -#define T_CAPABILITY_QOS (1 << 2) -#define T_CAPABILITY_AGGREGATION (1 << 3) +#define T_CAPABILITY_MULTI_CS BIT(0) +#define T_CAPABILITY_WIMAX BIT(1) +#define T_CAPABILITY_QOS BIT(2) +#define T_CAPABILITY_AGGREGATION BIT(3) struct hci_s { __be16 cmd_evt; diff --git a/drivers/staging/gdm72xx/netlink_k.c b/drivers/staging/gdm72xx/netlink_k.c index f3cdaa6..ee06bd15b 100644 --- a/drivers/staging/gdm72xx/netlink_k.c +++ b/drivers/staging/gdm72xx/netlink_k.c @@ -21,7 +21,7 @@ #include "netlink_k.h" #if !defined(NLMSG_HDRLEN) -#define NLMSG_HDRLEN ((int) NLMSG_ALIGN(sizeof(struct nlmsghdr))) +#define NLMSG_HDRLEN ((int)NLMSG_ALIGN(sizeof(struct nlmsghdr))) #endif #define ND_MAX_GROUP 30 @@ -29,8 +29,8 @@ #define ND_NLMSG_SPACE(len) (nlmsg_total_size(len) + ND_IFINDEX_LEN) #define ND_NLMSG_DATA(nlh) \ ((void *)((char *)nlmsg_data(nlh) + ND_IFINDEX_LEN)) -#define ND_NLMSG_S_LEN(len) (len+ND_IFINDEX_LEN) -#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len-ND_IFINDEX_LEN) +#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN) +#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN) #define ND_NLMSG_IFIDX(nlh) nlmsg_data(nlh) #define ND_MAX_MSG_LEN 8096 @@ -143,7 +143,7 @@ int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len) NETLINK_CB(skb).portid = 0; NETLINK_CB(skb).dst_group = 0; - ret = netlink_broadcast(sock, skb, 0, group+1, GFP_ATOMIC); + ret = netlink_broadcast(sock, skb, 0, group + 1, GFP_ATOMIC); if (!ret) return len; diff --git a/drivers/staging/gdm72xx/sdio_boot.c b/drivers/staging/gdm72xx/sdio_boot.c index ba94b5f..5e9b38f 100644 --- a/drivers/staging/gdm72xx/sdio_boot.c +++ b/drivers/staging/gdm72xx/sdio_boot.c @@ -96,7 +96,7 @@ static int download_image(struct sdio_func *func, const char *img_name) buf[1] = (len >> 8) & 0xff; buf[2] = (len >> 16) & 0xff; - memcpy(buf+TYPE_A_HEADER_SIZE, firm->data + pos, len); + memcpy(buf + TYPE_A_HEADER_SIZE, firm->data + pos, len); ret = sdio_memcpy_toio(func, 0, buf, len + TYPE_A_HEADER_SIZE); if (ret < 0) { dev_err(&func->dev, diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c index 39ca34031..c317ab9 100644 --- a/drivers/staging/gdm72xx/usb_boot.c +++ b/drivers/staging/gdm72xx/usb_boot.c @@ -292,8 +292,8 @@ static int em_download_image(struct usb_device *usbdev, const char *img_name, return -ENOMEM; } - strcpy(buf+pad_size, type_string); - ret = gdm_wibro_send(usbdev, buf, strlen(type_string)+pad_size); + strcpy(buf + pad_size, type_string); + ret = gdm_wibro_send(usbdev, buf, strlen(type_string) + pad_size); if (ret < 0) goto out; @@ -310,8 +310,8 @@ static int em_download_image(struct usb_device *usbdev, const char *img_name, else len = img_len; /* the last chunk of data */ - memcpy(buf+pad_size, firm->data + pos, len); - ret = gdm_wibro_send(usbdev, buf, len+pad_size); + memcpy(buf + pad_size, firm->data + pos, len); + ret = gdm_wibro_send(usbdev, buf, len + pad_size); if (ret < 0) goto out; @@ -319,7 +319,7 @@ static int em_download_image(struct usb_device *usbdev, const char *img_name, img_len -= DOWNLOAD_CHUCK; pos += DOWNLOAD_CHUCK; - ret = em_wait_ack(usbdev, ((len+pad_size) % 512 == 0)); + ret = em_wait_ack(usbdev, ((len + pad_size) % 512 == 0)); if (ret < 0) goto out; } diff --git a/drivers/staging/gdm72xx/usb_ids.h b/drivers/staging/gdm72xx/usb_ids.h index 7afb9ba..84a6d68 100644 --- a/drivers/staging/gdm72xx/usb_ids.h +++ b/drivers/staging/gdm72xx/usb_ids.h @@ -32,10 +32,10 @@ #define BL_PID_MASK 0xffc0 #define USB_DEVICE_BOOTLOADER(vid, pid) \ - {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)} + {USB_DEVICE((vid), ((pid) & BL_PID_MASK) | B_DOWNLOAD)} #define USB_DEVICE_BOOTLOADER_DRV(vid, pid) \ - {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)} + {USB_DEVICE((vid), ((pid) & BL_PID_MASK) | B_DOWNLOAD | B_DIFF_DL_DRV)} #define USB_DEVICE_CDC_DATA(vid, pid) \ {USB_DEVICE_INTF((vid), (pid), USB_CLASS_CDC_DATA)} @@ -44,40 +44,40 @@ static const struct usb_device_id id_table[] = { USB_DEVICE_BOOTLOADER(GCT_VID, GCT_PID1), USB_DEVICE_BOOTLOADER_DRV(GCT_VID, GCT_PID1), USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x1), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x2), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x3), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x4), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x5), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x6), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x7), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x8), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0x9), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xa), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xb), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xc), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xd), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xe), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1+0xf), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x1), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x2), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x3), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x4), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x5), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x6), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x7), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x8), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0x9), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xa), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xb), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xc), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xd), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xe), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID1 + 0xf), USB_DEVICE_BOOTLOADER(GCT_VID, GCT_PID2), USB_DEVICE_BOOTLOADER_DRV(GCT_VID, GCT_PID2), USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x1), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x2), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x3), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x4), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x5), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x6), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x7), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x8), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0x9), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xa), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xb), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xc), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xd), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xe), - USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2+0xf), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x1), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x2), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x3), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x4), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x5), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x6), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x7), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x8), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0x9), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xa), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xb), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xc), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xd), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xe), + USB_DEVICE_CDC_DATA(GCT_VID, GCT_PID2 + 0xf), {USB_DEVICE(GCT_VID, EMERGENCY_PID)}, { } -- 2.5.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel