[PATCH v3 00/13] Fix hfi1_ioctl locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ira Weiny <ira.weiny@xxxxxxxxx>

It was identified that hfi1_ioctl may sleep with a spin lock held.

This was identified publicly here:

http://www.spinics.net/lists/linux-rdma/msg29926.html

As well as by our internal development.

This series cleans up the code and parameter checks, as well as fixing the
locking.

---
Changes from v1
        Alter switch to just ignore set link state and default to return -ENOTTY
	Remove patch which introduced an intermediate bug and squash it in the
	final patch
		Series was 7 patches rather than 8

Changes from v2
	Split patch 1 (diag.c Correct code style issues) into 7 patches which
	each fix a specific checkpatch issue.
		Series is now 13 patches
	

Dennis Dalessandro (2):
  staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.
  staging/rdma/hfi1: Return immediately on error

Ira Weiny (11):
  staging/rdma/hfi1: diag.c use BIT macros
  staging/rdma/hfi1: diag.c fix alignment
  staging/rdma/hfi1: diag.c fix logical continuations
  staging/rdma/hfi1: diag.c fix white space errors
  staging/rdma/hfi1: diag.c change null comparisons
  staging/rdma/hfi1: diag.c add missing braces
  staging/rdma/hfi1: diag.c correct sizeof parameter
  staging/rdma/hfi1: Fix camel case variables
  staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors
  staging/rdma/hfi1: hfi1_ioctl remove setlink state
  staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

 drivers/staging/rdma/hfi1/diag.c | 464 +++++++++++++++++++--------------------
 1 file changed, 220 insertions(+), 244 deletions(-)

-- 
1.8.2

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux