Re: [PATCH net-next] hv_netvsc: rework link status change handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
Date: Fri, 27 Nov 2015 11:39:55 +0100

> There are several issues in hv_netvsc driver with regards to link status
> change handling:
> - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing
>   '/etc/init.d/network restart' and this is inappropriate and broken for
>   many reasons.
> - link_watch infrastructure only sends one notification per second and
>   in case of e.g. paired disconnect/connect events we get only one
>   notification with last status. This makes it impossible to handle such
>   situations in userspace.
> 
> Redo link status changes handling in the following way:
> - Create a list of reconfig events in network device context.
> - On a reconfig event add it to the list of events and schedule
>   netvsc_link_change().
> - In netvsc_link_change() ensure 2-second delay between link status
>   changes.
> - Handle RNDIS_STATUS_NETWORK_CHANGE as a paired disconnect/connect event.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Applied, thank you.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux