Re: [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote:
> 
> 
> On 2015년 11월 19일 15:23, Dan Carpenter wrote:
> >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
> >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
> >>this name could be confused index of txq_entry_t. It is index of tcp pending
> >>ack.
> >>
> >>It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
> >>
> >It is just a cleanup patch and not a bugfix patch so "fix" is the wrong
> >word here.  But the correct format for fixes tags is:
> >
> >Fixes: 123456789012 ('Title of patch')
> 
> I see, I learned another one. Thanks.

Git can do this automatically for you:
	 git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
I have an alias for this to make it easier to use frequently.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux