RE: [PATCH 17/33] staging: comedi: adv_pci_dio: remove defines used for the do registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, November 18, 2015 11:34 AM, Ian Abbott wrote:
> On 18/11/15 17:07, H Hartley Sweeten wrote:
>> These defines are only used to initialize the diosubd_data 'addr' members
>> in the boardinfo. For aesthetics, just open-code the values and remove the
>> defines.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>> Cc: Ian Abbott <abbotti@xxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> ---
>>   drivers/staging/comedi/drivers/adv_pci_dio.c | 32 +++++++++-------------------
>>   1 file changed, 10 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c b/drivers/staging/comedi/drivers/adv_pci_dio.c
>> index 578c646..a72b04e 100644
>> --- a/drivers/staging/comedi/drivers/adv_pci_dio.c
>> +++ b/drivers/staging/comedi/drivers/adv_pci_dio.c
> [snip]
>
>> @@ -233,7 +221,7 @@ static const struct dio_boardtype boardtypes[] = {
>>   		.cardtype	= TYPE_PCI1762,
>>   		.nsubdevs	= 3,
>>   		.sdi[1]		= { 16, 0x02, },	/* ISO DI 0-15 */
>> -		.sdo[1]		= { 16, PCI1762_RO, },
>> +		.sdo[1]		= { 16, 0x00, },	/* ISO DO 0-15 */
>
> The comment is slightly wrong.  Those are relay outputs.

Well... A relay output is isolated... :-)

Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux