On Wednesday 18 November 2015 10:42 PM, Greg KH wrote: > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning >> found by the checkpatch.pl tool. >> >> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@xxxxxxxxx> >> --- >> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c >> index b10d601..6226e02 100644 >> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c >> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c >> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ >> } >> >> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ >> -property_write(prop, signal size, mask, check) \ >> -property_read(prop, size, mask) >> +(property_write(prop, signal size, mask, check) \ >> +property_read(prop, size, mask)) > You didn't even test-build this patch, why not? > Greg KH, I have compiled the kernel by following these step: 1. copied the .config files 2. make defconfig 3. make -j6 It doesn't show me any warning. so I have tested on my side. -- Thanks and Regards, Jitendra Kumar Khasdev _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel