On Wed, Nov 18, 2015 at 01:43:36PM +0100, Christian Gromm wrote: > This patch makes function store_add_link initialize the pointer to an AIM > right before the channel is probed. > The patch description implies that this is a cleanup but looking at the patch it looks like a behavior change. Actually for quite a few of these it definitely is a bugfix but it's not clear what the bug would look like to the user. Please always be explicit. For example, calculating the offset badly seems like it might have security implications. Don't be ambiguous if that's the case. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel