On Tue, Nov 17, 2015 at 10:28:17PM +0000, Sell, Timothy C wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Tuesday, November 17, 2015 5:18 PM > > To: Romer, Benjamin M > > Cc: *S-Par-Maintainer; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and > > enhancements > > > > On Mon, Nov 16, 2015 at 03:22:10PM -0500, Benjamin Romer wrote: > > > This patch series fixes visorinput to remove the dependency on FB and > > > add dependency to INPUT, cleans up some formatting issues found with > > > checkpatch.pl, and adds the capability to change screen resolutions > > > without breaking mouse functionality. > > > > > > This is a resubmission of the series. > > > > You changed nothing based on the previous discussion, not exactly a good > > way to get a patch series accepted :( > > We relocated a devdata_put() in "[PATCH v2 1/7]" at the recommendation > of Dan Carpenter. I guess I was mistaken that I had convinced you in our > previous email discussion about the need for the lock. :-( I have the short-term memory of a squirrel, if someone can't see in the patch itself why it is working correctly, you haven't convinced anyone :) Please be descriptive in the changelog about _why_ you are doing something, so that everyone understands, not the least being yourself in 8 years when you get a bug report asking why you did something in a specific commit (a real example of what happened to me earlier today.) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
