Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: >> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf, >> return PTR_ERR(inmsg); >> >> if (hvt->on_msg(inmsg, count)) >> - return -EFAULT; >> + ret = -EFAULT; > > You fix this leak and then re-introduce it again directly in patch > 3/4. Such a shame ... Thanks for noticing! > Also it might be nice to preserve the error code. > > ret = hvt->on_msg(inmsg, count); > > kfree(inmsg); > > return ret ? ret : count; It seems on_msg() hooks can only return -EINVAL now but why not ... let's do it in v2. -- Vitaly _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
