Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/11/15 09:28, Lars-Peter Clausen wrote:
> On 11/14/2015 03:44 AM, Nizam Haider wrote:
>> Fix simple typo in comments
>>
>> Signed-off-by: Nizam Haider <nijamh@xxxxxxx>
> 
> Thanks for the patch.
> 
>> ---
>>  drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c
>> index cf44a6f..c8f889b 100644
>> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c
>> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c
>> @@ -64,7 +64,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
>>  		 * software scans: can be considered to be random access
>>  		 *   so efficient reading is just a case of minimal bus
>>  		 *   transactions.
>> -		 * software culled hardware scans:
>> +		 * software called hardware scans:
> 
> I don't think that's a typo. The non-patched version makes a lot more sense
> then the patched vesion.
Yup, that's me using some 'more unusual' English terminology, Perhaps the word
'dropped' would be clearer.

Also, that comment is now a little misleading as it is unusual / undesirable
to now do this in an individual driver.  The core demux code should take care
of it.

Hmm.. I'll make a note to reread the comments in that driver and see if any
others could do with a refresh.

Jonathan
> 
>>  		 *   occasionally a driver may process the nearest hardware
>>  		 *   scan to avoid storing elements that are not desired. This
>>  		 *   is the fiddliest option by far.
>>
> 

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux