Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/11/2015 13:44, Ranjith T wrote:
Is this patch is fine?.

Thanks,
Ranjith T.

Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't really "T".

On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@xxxxxxxxx> wrote:
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T <ranjithece24@xxxxxxxxx>
---
  drivers/staging/comedi/drivers/comedi_parport.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
  #define PARPORT_DATA_REG       0x00
  #define PARPORT_STATUS_REG     0x01
  #define PARPORT_CTRL_REG       0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

  static int parport_data_reg_insn_bits(struct comedi_device *dev,
                                       struct comedi_subdevice *s,
--
1.7.10.4

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux