On Wed, Nov 11, 2015 at 12:42:21AM +0100, Arnd Bergmann wrote:
> A recent cleanup added a reference to struct net_device, but
> that structure is not always visible in the context of the
> declaration, so we may get a compile-time error:
>
> In file included from wilc1000/host_interface.c:5:0:
> wilc1000/host_interface.h:705:46: warning: 'struct net_device' declared inside parameter list
> s32 wilc_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
>
> This adds a forward-declaration for the structure name to avoid
> that error.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: d5382219138d ("staging: wilc1000: host_int_init: add argument net_device")
> ---
> drivers/staging/wilc1000/host_interface.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h
> index 57e1d424afdc..29a92d690384 100644
> --- a/drivers/staging/wilc1000/host_interface.h
> +++ b/drivers/staging/wilc1000/host_interface.h
> @@ -369,6 +369,7 @@ s32 host_int_scan(struct host_if_drv *hWFIDrv, u8 u8ScanSource,
> s32 hif_set_cfg(struct host_if_drv *hWFIDrv,
> struct cfg_param_val *pstrCfgParamVal);
> s32 hif_get_cfg(struct host_if_drv *hWFIDrv, u16 u16WID, u16 *pu16WID_Value);
> +struct net_device;
I think this is already fixed in my staging-testing branch, right?
and as Joe said, a #include would be nicer.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
