On Tue, Nov 10, 2015 at 03:43:50AM +0800, kbuild test robot wrote: > drivers/staging/lustre/lustre/llite/xattr.c:199:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Shivani Bhardwaj <shivanib134@xxxxxxxxx> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > --- > > xattr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/staging/lustre/lustre/llite/xattr.c > +++ b/drivers/staging/lustre/lustre/llite/xattr.c > @@ -192,11 +192,10 @@ int ll_setxattr_common(struct inode *ino > valid, name, pv, size, 0, flags, > ll_i2suppgid(inode), &req); > #ifdef CONFIG_FS_POSIX_ACL > - if (new_value != NULL) > /* > * Release the posix ACL space. > */ > - kfree(new_value); > + kfree(new_value); Looks like a bug in coccinelle, the comment line should also be indented to the left. Julia, any ideas? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
