On Nov 7, 2015, at 04:15, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Fri, Nov 06, 2015 at 10:04:41PM +0000, Simmons, James A. wrote: >>> From: devel [mailto:driverdev-devel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Shivani Bhardwaj >>> Sent: Friday, November 06, 2015 12:18 PM >>> To: gregkh@xxxxxxxxxxxxxxxxxxx >>> Cc: oleg.drokin@xxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; andreas.dilger@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >>> Subject: [PATCH 1/3] Staging: lustre: module: Replace function calls >>> >>> Replace the calls of function cfs_trace_free_string_buffer() with >>> kfree() as the former function is not required. >>> >>> Signed-off-by: Shivani Bhardwaj <shivanib134@xxxxxxxxx> >>> --- >>> drivers/staging/lustre/lustre/libcfs/module.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Acked-by: James Simmons <jsimmons@xxxxxxxxxxxxx> >> >> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c >> index 50e8fd2..516a9e7 100644 >> --- a/drivers/staging/lustre/lustre/libcfs/module.c >> +++ b/drivers/staging/lustre/lustre/libcfs/module.c >> @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write, >> } else { > > Why do your acks include the original diff without the "> " prefix? How > are you even managing that trick? I was wondering the same, though it does look nicer. Cheers, Andreas _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
