On Thu, Nov 05, 2015 at 07:35:36PM +0530, Shraddha Barke wrote:
> Declare the function fwtty_port_put as static since it is used
> only in this particular file. Also remove the corresponding
> declaration from header file.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@xxxxxxxxx>
> ---
> drivers/staging/fwserial/fwserial.c | 3 +--
> drivers/staging/fwserial/fwserial.h | 2 --
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index b3ea4bb..b676c48 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -893,11 +893,10 @@ static void fwserial_destroy(struct kref *kref)
> kfree(serial);
> }
>
> -void fwtty_port_put(struct fwtty_port *port)
> +static void fwtty_port_put(struct fwtty_port *port)
> {
> kref_put(&port->serial->kref, fwserial_destroy);
> }
> -EXPORT_SYMBOL(fwtty_port_put);
>
> static void fwtty_port_dtr_rts(struct tty_port *tty_port, int on)
> {
> diff --git a/drivers/staging/fwserial/fwserial.h b/drivers/staging/fwserial/fwserial.h
> index 8d791ae..e13fe33 100644
> --- a/drivers/staging/fwserial/fwserial.h
> +++ b/drivers/staging/fwserial/fwserial.h
> @@ -342,8 +342,6 @@ static const char loop_dev_name[] = "fwloop";
> extern struct tty_driver *fwtty_driver;
>
> struct fwtty_port *fwtty_port_get(unsigned index);
You can do the same thing with fwtty_port_get(), please send a follow-on
patch that does that.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
