On Thu, Nov 05, 2015 at 10:58:36AM +0300, Dan Carpenter wrote:
On Wed, Nov 04, 2015 at 11:14:57PM -0500, jubin.john@xxxxxxxxx wrote:
From: Sebastian Sanchez <sebastian.sanchez@xxxxxxxxx>
Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
output for every context that is open by PSM.
Just delete it... People get scared about deleting debug code but you
can add it back if there is really a bug.
/me chants, "delete. delete. delete."
I would tend to agree with that, but in this case we want to keep a way to
get this information without making code changes. We just don't want it to
spew to the console/syslog all the time. Instead we are using the trace
mechanism which lets the user selectively turn on the messages when needed.
Perhaps we should expand on the commit message to make this more clear?
-Denny
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
