On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.weiny@xxxxxxxxx wrote: > From: Vennila Megavannan <vennila.megavannan@xxxxxxxxx> > > Add a module paramter to toggle prescan/Fast ECN Detection. > > In addition change the PRESCAN_RXQ Kconfig default to "yes". > > Reviewed-by: Arthur Kepner<arthur.kepner@xxxxxxxxx> > Reviewed-by: Mike Marciniszyn<mike.marciniszyn@xxxxxxxxx> > Signed-off-by: Vennila Megavannan<vennila.megavannan@xxxxxxxxx> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> Hm... In the original code we had the config entry but the code to support this was actually disabled. Now we are turning on the config entry by default but the module parameter defaults to disabled. I think the documentation is a bit tricky because it should say that actually enabling the config is not enough, it's still disabled. Do we really need the config to be there? Distros are going to enable it. Who is it who wants to disable the config? Also is it better to default to off or on for this code, what are the upsides and downsides of that choice? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
