Really, it's probably easiest to just fold all these patches together as one patch. Re-writing a function is considered "one thing" under the "one thing per patch" rule. Re-writing a file is not considered one thing. Hopefully that's helpful in understanding where the line is. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel