Re: [PATCH 29/38] staging: wilc1000: remove goto from linux_wlan_start_firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 02, 2015 at 05:51:12PM +0900, Glen Lee wrote:
>  	PRINT_D(INIT_DBG, "Waiting for Firmware to get ready ...\n");
>  	ret = linux_wlan_lock_timeout(&wilc->sync_event, 5000);
>  	if (ret) {
>  		PRINT_D(INIT_DBG, "Firmware start timed out");
> -		goto _fail_;
> +		return ret;
>  	}
>  	PRINT_D(INIT_DBG, "Firmware successfully started\n");
>  
> -_fail_:
>  	return ret;

In a later patch, could you change this from "return ret;" to
"return 0;"

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux