On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@xxxxxxxxx> wrote: > > BIT macro is used for defining bit location instead of shifting > > operator - coding style issue > > > #define APCI1032_CTRL_INT_OR (0 << 1) > > > +#define APCI1032_CTRL_INT_AND BIT(1) > > And now you have two styles at the same time. I wouldn't change the > current definitions. Yes you should, just use BIT(0) for this one. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
