Re: [PATCH 38/80] staging: wilc1000: rename au8Bssid of struct ba_session_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2015년 10월 29일 01:56, Dan Carpenter wrote:
On Wed, Oct 28, 2015 at 03:59:58PM +0900, Glen Lee wrote:
From: Leo Kim <leo.kim@xxxxxxxxx>

This patch renames au8Bssid of struct ba_session_info to bssid
to avoid CamelCase naming convention.
And, some debug logs modified because 80 ending line over warnings.

Signed-off-by: Leo Kim <leo.kim@xxxxxxxxx>
Signed-off-by: Glen Lee <glen.lee@xxxxxxxxx>
---
  drivers/staging/wilc1000/host_interface.c | 32 ++++++++++++++++++-------------
  drivers/staging/wilc1000/host_interface.h |  2 +-
  2 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 9ad98fd..48a232f 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2715,10 +2715,14 @@ static s32 Handle_AddBASession(struct host_if_drv *hif_drv,
  	int AddbaTimeout = 100;
  	char *ptr = NULL;
- PRINT_D(HOSTINF_DBG, "Opening Block Ack session with\nBSSID = %.2x:%.2x:%.2x\nTID=%d\nBufferSize == %d\nSessionTimeOut = %d\n",
-		strHostIfBASessionInfo->au8Bssid[0],
-		strHostIfBASessionInfo->au8Bssid[1],
-		strHostIfBASessionInfo->au8Bssid[2],
+	PRINT_D(HOSTINF_DBG, "Opening Block Ack session with \
+		\nBSSID = %.2x:%.2x:%.2x \
+		\nBufferSize == %d \
+		\nSessionTimeOut = %d \
+		\nTID=%d\n",
+		strHostIfBASessionInfo->bssid[0],
+		strHostIfBASessionInfo->bssid[1],
+		strHostIfBASessionInfo->bssid[2],
  		strHostIfBASessionInfo->u16BufferSize,
  		strHostIfBASessionInfo->u16SessionTimeout,
  		strHostIfBASessionInfo->u8Ted);
This should be a bunch of printks so that we have the correct debug
level at the start of each line.

Thank you for your advice.
We will use netdev_xxx print format later with a bunch of prints when the function gets access net_device.
For now, continuation \ will be deleted and will be like,

	PRINT_D(HOSTINF_DBG, "Opening Block Ack session with BSSID = %02x:%02x:%02x TID=%d BufferSize == %d SessionTimeOut = %d\n",
		etc...

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux