On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote: > This fixes all Alignment should match open parenthesis > messages from checkpatch.pl What you suggest is not at all generally accepted kernel style. > diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c [] > @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type) > return -ENOMEM; > skb_reserve(skb_out, NET_IP_ALIGN); > > - memcpy(skb_put(skb_out, mac_header_len), mac_header_data, > + memcpy( > + skb_put(skb_out, mac_header_len), mac_header_data, > mac_header_len); What's desired here is: memcpy(skb_put(skb_out, mac_header_len), mac_header_data, mac_header_len); Second line should be: [tab][7 spaces]mac_header_len); etc... btw: Please run your _patches_ through checkpatch.pl, not just use it to find style issues in files. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
