Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
> 
> -Prefer eth_broadcast_addr() over memset()
> 
> Signed-off-by: Punit Vara <punitvara@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/host_interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 09a6c98..87b4eb8 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
>  	msg.drv = hif_drv;
>  
>  	if (pu8MacAddr == NULL)
> -		memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
> +		eth_broadcast_addr(pstrDelStationMsg->mac_addr);
>  	else
>  		memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
>  

Doesn't apply to my staging.git tree at all :(
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux