Hi, The sm750 adapter state is currently represented with several structures that are nested into each other. That division does not seem necessary and single structure is quite enough to hold the adapter state. These patchset refactors the code to merge the adapter state representaion into a single sturcture along with several minor cleanups. Build tested only. Mike Rapoport (19): staging: sm750fb: replace lynx_cursor methods with function calls staging: sm750fb: remove unused SPC_SM750 define staging: sm750fb: replace PADDING macro with ALIGN staging: sm750fb: remove unused smi_indent variable staging: sm750fb: merge sm750_hw.h into sm750.h staging: sm750fb: rename struct sm750_share to sm750_dev staging: sm750fb: rename 'struct sm750_dev' variables to sm750_dev staging: sm750fb: merge struct sm750_state into struct sm750_dev staging: sm750fb: remove unused PROC_SPEC_* typedefs staging: sm750fb: replace lynx_share with sm750_dev in lynxfb_par staging: sm750fb: remove hw_sm750_getVMSize function staging: sm750fb: replace lynx_share with sm750_dev in function calls staging: sm750fb: use 'struct sm750_dev *' instead of 'void *' staging: sm750fb: use sm750_dev with pci_{get,set}_drvdata staging: sm750fb: fix wrong indentation staging: sm750fb: remove unused field in lynx_cursor staging: sm750fb: merge lynx_share into sm750_dev staging: sm750fb: remove '#ifdef CAP_EXP*' conditionals staging: sm750fb: remove unused fields from struct sm750_dev drivers/staging/sm750fb/sm750.c | 354 ++++++++++++++++--------------------- drivers/staging/sm750fb/sm750.h | 102 ++++++++--- drivers/staging/sm750fb/sm750_hw.c | 94 +++++----- drivers/staging/sm750fb/sm750_hw.h | 98 ---------- 4 files changed, 269 insertions(+), 379 deletions(-) delete mode 100644 drivers/staging/sm750fb/sm750_hw.h -- 2.1.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel