On Wed, Oct 21, 2015 at 04:18:06PM +0300, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 10:11:16PM -0400, ira.weiny@xxxxxxxxx wrote: > > From: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx> > > > > This additional call is a regression from qib. For small messages the progress > > routine always builds one and clears out the ahg state when the queue has gone > > to empty which is the predominant case for small messages. > > > > Inline the routine to mitigate the call and move the routine to qp.h for scope > > reasons. > > > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > > Signed-off-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx> > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > --- > > The whole point of this patch is to do: > > > - if (qp->s_sde) > > + if (qp->s_sde && qp->s_ahgidx >= 0) > > It was not at all clear from the changelog and it was difficult to tell > because we moved code around as well. I've cleaned up the commit message. v3 should be on its way after I make sure I have addressed all your comments on all the patches. Ira > > regards, > dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel