Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
> Use netdev private member wilc instead of g_linux_wlan and Change argument wilc
> with dev in the function request_threaded_irq to pass back to handler
> the function isr_uh_routine.
> 
> Signed-off-by: Glen Lee <glen.lee@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/linux_wlan.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index b036b96..7b0614d 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -229,10 +229,15 @@ static int dev_state_ev_handler(struct notifier_block *this, unsigned long event
>  #if (defined WILC_SPI) || (defined WILC_SDIO_IRQ_GPIO)
>  static irqreturn_t isr_uh_routine(int irq, void *user_data)
>  {
> +	perInterface_wlan_t *nic;
> +	struct wilc *wl;
> +
> +	nic = netdev_priv(usedata);

This patch breaks the build, which means you didn't even test build the
series :(

Please redo this whole series and test your patches better.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux