On Fri, Oct 23, 2015 at 5:10 PM, Dilger, Andreas <andreas.dilger@xxxxxxxxx> wrote: > On 2015/10/22, 22:30, "Nilesh Kokane" <nilesh.kokane05@xxxxxxxxx> wrote: >>Fixed- Return of an errno should typically be negative (ie: return >>-EAGAIN) > > Nak. Please do not change these function return values. They are > converted as necessary by the callers before returning to userspace, but > allow the code to distinguish between errors generated internally or from > lower networking layers. > > As you will note, many of them are explicitly annotated with comments that > they are returning positive values. The patch as it stands would totally > break the code. Ok. I'll take care next time. -- //Nilesh Kokane _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
