On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote: > > > > Perhaps I did not chose my words carefully enough. > > > > The largest issue on the TODO list is the refactoring of the code to be > > shared between the hfi1 and qib driver. While the hardware between hfi1 > > and qib is similar and thus the initial code looked similar, our > > performance tuning on hfi1 has revealed that some changes will be required > > to the hfi1 code to fully utilize the hardware. We would like to get these > > updates in to make sure that the refactoring work is done properly for the > > 2 hardware types. > > Please keep in mind that there are 3 HW types (our SoftRoCE driver) > that needs to be part of the framework. Understood, however, unlike SoftRoCE, qib and hfi currently share a lot of code to drive the hardware. The underlying reason for the TODO item "Remove software processing of IB protocol..." is because we have a large amount of duplicated code between these drivers. _Some_ of which, at a high level, is sharable with SoftRoCE. These patches (and more to follow), further differentiate the 2 drivers along hardware lines. Accepting these patches will help us make sure that we don't create some common code between qib and hfi which, because of our testing we now know, needs to be separated out. This is a separate issue from the higher level code sharing which will be done with SoftRoCE. Ira _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
