This series cleans up a bit firmware loading code. I had it stashed for some time, but finally was able to repackage patches to a "reviewable" format. It generates one new LONG_LINE warning, but breaking it would make code less readable (and it's just 1 character). Series was target tested and seems not to break things (It's usually easy to tell that firmware loading code fails anyway). It should apply cleanly to staging-next/staging-testing (c3af8a28) This probably is my last series (for this driver), as I'll try to rewrite it from scratch like Jes Sorensen is doing for USB dongles. Mateusz Kulikowski (16): staging: rtl8192e: rtl_dm: Use proper packet type staging: rtl8192e: cmdpkt: Use packettype properly staging: rtl8192e: cmdpkt: Simplify argument names staging: rtl8192e: cmdpkt: Reorder arguments staging: rtl8192e: cmdpkt: Pass data as const void* staging: rtl8192e: Use macro to represent fragmentation threshold staging: rtl8192e: cmd_pkt: Handle INIT packets staging: rtl8192e: Add rt_fw_blob staging: rtl8192e: Rename rt_firmware::firmware_status to status staging: rtl8192e: init_fw: Drop unneded check staging: rtl8192e: Add _rtl92e_wait_for_fw() staging: rtl8192e: Add _rtl92e_fw_prepare staging: rtl8192e: Swap firmware endian in _rtl92e_fw_prepare() staging: rtl8192e: Remove _rtl92e_fw_download_code() staging: rtl8192e: fw: Use netdev_dbg instead of RT_TRACE staging: rtl8192e: _rtl92e_fw_boot_cpu: Remove unneeded goto drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 58 +++-- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 4 +- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 +- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c | 263 ++++++--------------- .../staging/rtl8192e/rtl8192e/r8192E_firmware.h | 19 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 + drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- 7 files changed, 131 insertions(+), 225 deletions(-) -- 2.1.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel