Re: [PATCH] drivers:staging:gdm72xx: Fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 14, 2015 at 09:40:37PM +0300, Janis Gengeris wrote:
> Fixes coding style warnings as reported by checkpatch.pl.

Please be more elaborate and describe what warning was fixed
 
> Signed-off-by: Janis Gengeris <janis.gengeris@xxxxxxxxx>
> ---
>  drivers/staging/gdm72xx/gdm_wimax.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
> index 6e8dbaf..69f00cc 100644
> --- a/drivers/staging/gdm72xx/gdm_wimax.c
> +++ b/drivers/staging/gdm72xx/gdm_wimax.c
> @@ -581,8 +581,8 @@ static int gdm_wimax_get_prepared_info(struct net_device *dev, char *buf,
>  		}
>  
>  		pos += gdm_wimax_hci_get_tlv(&buf[pos], &T, &L, &V);
> -		if (T == TLV_T(T_MAC_ADDRESS)) {
> -			if (L != dev->addr_len) {
> +		if (TLV_T(T_MAC_ADDRESS) == T) {
> +			if (dev->addr_len != L) {

The change is already in the Greg's staging/staging-testing tree

>  				netdev_err(dev,
>  					   "%s Invalid information result T/L [%x/%d]\n",
>  					   __func__, T, L);
> -- 
> 2.4.6
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux