"K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> writes: > From: Jake Oshins <jakeo@xxxxxxxxxxxxx> > > This defines the channel type for PCI front-ends in Hyper-V VMs. > > Signed-off-by: Jake Oshins <jakeo@xxxxxxxxxxxxx> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > drivers/hv/channel_mgmt.c | 3 +++ > include/linux/hyperv.h | 11 +++++++++++ > 2 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c > index 652afd1..1ae615b 100644 > --- a/drivers/hv/channel_mgmt.c > +++ b/drivers/hv/channel_mgmt.c > @@ -358,6 +358,7 @@ enum { > SCSI, > NIC, > ND_NIC, > + HV_PCIE, > MAX_PERF_CHN, > }; It seems all other members of the enum don't have HV_ prefix... should we add it there or remove it from HV_PCIE? > > @@ -375,6 +376,8 @@ static const struct hv_vmbus_device_id hp_devs[] = { > { HV_NIC_GUID, }, > /* NetworkDirect Guest RDMA */ > { HV_ND_GUID, }, > + /* PCI Express Pass Through */ > + { HV_PCIE_GUID, }, > }; And here everything is prefixed with HV_ ... so I'd say we add HV_ to all members of the previously mentioned enum. [...] -- Vitaly _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel