Hi Chaehyun,
On Fri, Oct 2, 2015 at 10:44 PM, Chaehyun Lim <chaehyun.lim@xxxxxxxxx> wrote:
> This patch replaces s32Error with result to avoid camelcase.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@xxxxxxxxx>
> ---
> drivers/staging/wilc1000/host_interface.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 65bd325..566e618 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -5317,7 +5317,7 @@ s32 host_int_get_rx_power_level(tstrWILC_WFIDrv *hWFIDrv, u8 *pu8RxPowerLevel,
> */
> int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *hWFIDrv, u8 u8ChNum)
> {
> - int s32Error = 0;
> + int result = 0;
> tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *)hWFIDrv;
> struct host_if_msg msg;
>
> @@ -5332,13 +5332,13 @@ int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *hWFIDrv, u8 u8ChNum)
> msg.body.channel_info.u8SetChan = u8ChNum;
> msg.drvHandler = hWFIDrv;
>
> - s32Error = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
> - if (s32Error) {
> + result = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
> + if (result) {
> PRINT_ER("wilc mq send fail\n");
> - s32Error = -EINVAL;
> + result = -EINVAL;
Why not just have
return -EINVAL;
here?
> }
>
> - return s32Error;
> + return result;
and
return 0;
here?
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
