It looks like this is worth checking. The direct return preceeded by a failure path with a goto may also be a problem. julia On Wed, 30 Sep 2015, kbuild test robot wrote: > CC: kbuild-all@xxxxxx > TO: Leo Kim <leo.kim@xxxxxxxxx> > CC: "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx> > CC: Tony Cho <tony.cho@xxxxxxxxx> > CC: devel@xxxxxxxxxxxxxxxxxxxx > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing > head: 5b62408ffe42ffce28e94bc5e7a6dec45e6456ee > commit: 24db713fe5325917690c2c793a6321aa0b11a0c8 [416/970] staging: wilc1000: remove the macro WILC_ERRORREPORT > :::::: branch date: 26 minutes ago > :::::: commit date: 13 days ago > > >> drivers/staging/wilc1000/wilc_msgqueue.c:78:2-8: preceding lock on line 73 > > git remote add staging https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > git remote update staging > git checkout 24db713fe5325917690c2c793a6321aa0b11a0c8 > vim +78 drivers/staging/wilc1000/wilc_msgqueue.c > > bb9c2e7a Chaehyun Lim 2015-08-19 67 if (pHandle->bExiting) { > 24db713f Leo Kim 2015-09-16 68 PRINT_ER("pHandle fail\n"); > 24db713f Leo Kim 2015-09-16 69 s32RetStatus = -EFAULT; > 24db713f Leo Kim 2015-09-16 70 goto ERRORHANDLER; > c5c77ba1 Johnny Kim 2015-05-11 71 } > c5c77ba1 Johnny Kim 2015-05-11 72 > c5c77ba1 Johnny Kim 2015-05-11 @73 spin_lock_irqsave(&pHandle->strCriticalSection, flags); > c5c77ba1 Johnny Kim 2015-05-11 74 > c5c77ba1 Johnny Kim 2015-05-11 75 /* construct a new message */ > 5c07828f Chaehyun Lim 2015-08-17 76 pstrMessage = kmalloc(sizeof(Message), GFP_ATOMIC); > 7ae43363 Leo Kim 2015-09-16 77 if (!pstrMessage) > 7ae43363 Leo Kim 2015-09-16 @78 return -ENOMEM; > c5c77ba1 Johnny Kim 2015-05-11 79 pstrMessage->u32Length = u32SendBufferSize; > c5c77ba1 Johnny Kim 2015-05-11 80 pstrMessage->pstrNext = NULL; > d9998a91 Chaehyun Lim 2015-09-08 81 pstrMessage->pvBuffer = kmalloc(u32SendBufferSize, GFP_ATOMIC); > > :::::: The code at line 78 was first introduced by commit > :::::: 7ae433631eacd0f0aaa749baef4c7f6baa5b3936 staging: wilc1000: remove a macro WILC_NULLCHECK > > :::::: TO: Leo Kim <leo.kim@xxxxxxxxx> > :::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
