On Sep 28, 2015, at 10:08 PM, Greg Kroah-Hartman wrote:
> On Mon, Sep 28, 2015 at 11:36:01AM +0200, Arnd Bergmann wrote:
>> On Sunday 27 September 2015 16:46:06 green@xxxxxxxxxxxxxx wrote:
>>> From: Oleg Drokin <green@xxxxxxxxxxxxxx>
>>>
>>> This is a large patch to remove all dead code from obdclass and
>>> ptlrpc, purely removing functions and declarations now, so
>>> despite the size should be easy enough to verify.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>> Signed-off-by: Oleg Drokin <green@xxxxxxxxxxxxxx>
>>
>> Thanks for all the work to split out the smaller patches from my
>> larger code removal!
>>
>> There is one small point about the attribution though: your split
>> out patches now have 'From: Oleg Drokin <green@xxxxxxxxxxxxxx>' along
>> wtih 'Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>', which is
>> inconsistent. For the larger chunks of patches that you took from me
>> and that retain my 'Signed-off-by', it would be nice if you could
>> set the author field to me for consistency as well.
>>
>> For the smaller patches for which writing the changelog was likely
>> more work than doing the patch, it's fine if you claim authorship,
>> but if you do that then please change the 'Signed-off-by' to
>> 'Reported-by' or 'Suggested-by' for me, so the author field
>> matches the first Signed-off-by.
>
> I agree, this isn't good. I've applied the first 47 patches in this
> series as they authorship info all seemed correct up until then.
>
> Oleg, can you rebase and resend the remaining ones after fixing this up?
Sure.
In fact I am not sure why the author got reset in that one in the
first place.
Bye,
Oleg
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
