On Mon, Sep 28, 2015 at 09:54:45PM +0100, Luis de Bethencourt wrote: > Remove the unused code, which isn't implemented yet, using #if 0. > > Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> > --- > > Hi, > > The code after the return is dead code. My understanding is that it is > there for when the output commands are implemented in the future. > Meanwhile it would be clearer if the code is removed with #if 0. > > Thanks, > Luis > > drivers/staging/comedi/drivers/ni_tiocmd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c > index 9b124b0..728c7f4 100644 > --- a/drivers/staging/comedi/drivers/ni_tiocmd.c > +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c > @@ -158,11 +158,13 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s) > "output commands not yet implemented.\n"); > return -ENOTSUPP; > > +#if 0 /* unused */ > counter->mite_chan->dir = COMEDI_OUTPUT; > mite_prep_dma(counter->mite_chan, 32, 32); > ni_tio_configure_dma(counter, true, false); > mite_dma_arm(counter->mite_chan); > return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE); > +#endif That's not clear at all, if the code isn't needed, let's just delete it, why is it here at all? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
