On Mon, Sep 28, 2015 at 4:48 PM, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: >> On 09/26/2015 11:49 AM, Punit Vara wrote: >> >This patch is to the rtl871x_ioctl_linux.c that fixes up following >> >warning reported by checkpatch.pl : >> > >> >- Comparisons should place the constant on the right side of the test >> > >> >Signed-off-by: Punit Vara <punitvara@xxxxxxxxx> >> >> This warning is crap. WTF difference does it make???? The compiler >> does not care, and any reader with any piece of a brain is not going >> to be confused! >> >> This patch and all others like it are just meaningless source churning! >> >> This author has made such a royal mess of his patches that I >> recommend that ALL of them be dropped. In addition, we should >> continue to drop his changes until he learns how to use git to >> generate N/M patches, and until he reads the documentation on patch >> submission. > Excuse me for my ignorance, but I still can not see what was wrong with > his patch. checkpatch is giving warning and he has fixed it. As far as > sending in series is concerned, he is a newbie and after telling him how > to generate patches in series he has learnt that. I have already told > him that his patches might be dropped as they are not in series and he > is ready to resend in series as soon as Greg confirms that they are > dropped. And as long as the driver is in staging there will be source > churning, isn't it? > If i remember correctly I was told that for a driver to be moved out of > staging the primary thing is that all checkpatch warnings needs to fixed. > So if this driver has to move out of staging someday then these warnings > also has to be fixed by someone. > > regards > sudip Thank you for understanding my situation @Sudip @Dan Carpenter .. First I have planned to clean all the warning whatever it may be silly or some serious. So that by cleaning those I can easily understand the whole process . I was thinking to dig into TODO list and followed by writing any driver. Greg please confirm me what should I do ? Do i touch any rtl* ? It is first time I am working with this much huge project .So may be I dont know what warnings are priority and what are not ? I felt proud when my first patch was accepted .Execuse me @Larry @Joshua if I irritate you by sending so many patches in sequence but I am happy to clean all the staging driver warning first. So that every programmer can focus on programming only not on cleanpatch warnings . Regards, Punit _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
