On Sun, Sep 27, 2015 at 01:59:17PM +0530, Pinkesh Jain wrote: > There were many warnings and error given by checkpatch.pl and most of them were > almost of the same type so i believed a single patch is enough to do the > cleanup. > > 1. Remove errors of the struct declaration (foo*bar to foo *bar) > 2. Removed warnings of 'spaces before comma'. > 3. Added space after enum declaration and before opening of paranthesis. > 4. removed spaces between function calls (func () to func() ) > 5. Still there are a lot of warnings related to only line lengths but removing > then would not make sense and would leave the code unreadable. > > There were one or two more of such kind of very small code refactoring that i > did. Since they were not that important, also i 'Did Not Alter' any other part > of functioning code so i made the changes in a single patch. > > I am new here and this is my first patch so please give me enough suggestions > and reviews for what i do, so that i can get familiar with the community > guidelines. > > If i do anything wrong then please correct me. > > Questions: > 1.) Do i need to mention all this changes that i wrote about in the commit as > they are very descriptive? I tried to be brief in the commit message. Be descriptive. > 2.) Do i need to split the changes in separate commits, as one of the members > pointed out. yes. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
