[PATCH v2] staging: sm750fb: replace twoToPowerOfx with shift operator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The function twoToPowerOfx that iteratively calculates the power of 2
may be replaced with shift operator

Signed-off-by: Mike Rapoport <mike.rapoport@xxxxxxxxx>
---
v2:
- fix changelog spelling
- break long line

 drivers/staging/sm750fb/ddk750_chip.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 5e6798e..8a74a1b 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -33,20 +33,10 @@ logical_chip_type_t getChipType(void)
 	return chip;
 }
 
-
-inline unsigned int twoToPowerOfx(unsigned long x)
-{
-	unsigned long i;
-	unsigned long result = 1;
-
-	for (i = 1; i <= x; i++)
-		result *= 2;
-	return result;
-}
-
 inline unsigned int calcPLL(pll_value_t *pPLL)
 {
-	return (pPLL->inputFreq * pPLL->M / pPLL->N / twoToPowerOfx(pPLL->OD) / twoToPowerOfx(pPLL->POD));
+	return (pPLL->inputFreq * pPLL->M / pPLL->N / (1 << pPLL->OD) /
+		(1 << pPLL->POD));
 }
 
 unsigned int getPllValue(clock_type_t clockType, pll_value_t *pPLL)
@@ -524,12 +514,12 @@ pll_value_t *pPLL           /* Structure to hold the value to be set in PLL */
 #endif
 
 	/* Work out 2 to the power of POD */
-	podPower = twoToPowerOfx(POD);
+	podPower = 1 << POD;
 
 	/* OD has only 2 bits [15:14] and its value must between 0 to 3 */
 	for (OD = 0; OD <= 3; OD++) {
 		/* Work out 2 to the power of OD */
-		odPower = twoToPowerOfx(OD);
+		odPower = 1 << OD;
 
 #ifdef VALIDATION_CHIP
 	if (odPower > 4)
-- 
2.1.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux