On 23/09/15 20:16, H Hartley Sweeten wrote:
Tidy up this driver and fix all the checkpatch.pl issues. H Hartley Sweeten (11): staging: comedi: rtd520: prefer using the BIT macro staging: comedi: rtd520: fix logical continuations staging: comedi: rtd529: usleep_range is preferred over udelay staging: comedi: rtd520: rename rtd520Boards staging: comedi: rtd520: move constants to right side of comparisons staging: comedi: rtd520: remove unnecessary comments from rtd_ao_winsn() staging: comedi: rtd520: convert DAC register defines to macros staging: comedi: rtd520: tidy up rtd_ao_winsn() staging: comedi: rtd520: remove unnecessary function desc. block comments staging: comedi: rtd520: tidy up block comments staging: comedi: rtd520: use DIV_ROUND_CLOSEST and DIV_ROUND_UP macros drivers/staging/comedi/drivers/rtd520.c | 257 ++++++++++++++------------------ 1 file changed, 108 insertions(+), 149 deletions(-)
Looks fine apart from patch 08, which I think will corrupt the negative half of the analog output in bipolar ranges.
For patches 01-07, 09-11: Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
