Re: [PATCH v4] staging: unisys: Add s-Par visorhba

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/23/2015 01:00 PM, Greg KH wrote:
v4:
* remove all BUG() and BUG_ON() - do not crash the kernel

You just deleted them?  No taking into account that you should just
handle issues like this in a run-time-safe way instead?
	
Removing them altogether was a better way to handle the problems overall. In both spots, the BUG_ON() was catching things on the client side of the driver that were actually a problem for the I/O service partition - bad values going in which could cause the service partition to crash. Obviously, crashing the guest was a bad solution, and it left an opening where someone could crash the service partition on purpose, so we needed to be able to handle things the right way.

I apologize for the lack of information in the versioning. I will collect up all of the changes from each version, and send a v5 with comprehensive information. :)

-- Ben
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux