Hi!
> > +++ b/drivers/fpga/fpga-mgr.c
> > @@ -0,0 +1,382 @@
> [..]
> > +int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf,
> > + size_t count)
> > +{
> > + struct device *dev = &mgr->dev;
> > + int ret;
> > +
> > + if (!mgr)
> > + return -ENODEV;
>
> This seems overly defensive.
>
> [..]
> > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags,
> > + const char *image_name)
> > +{
> > + struct device *dev = &mgr->dev;
> > + const struct firmware *fw;
> > + int ret;
> > +
> > + if (!mgr)
> > + return -ENODEV;
>
> Again; I'm of the opinion this is needlessly defensive.
Not only that, it can never happen. mgr is already dereferenced above.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
