Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
>  /**
> + * dprc_set_obj_label() - Set object label.
> + * @mc_io:	Pointer to MC portal's I/O object
> + * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token:	Token of DPRC object
> + * @obj_type:	Object's type
> + * @obj_id:	Object's ID
> + * @label:	The required label. The maximum length is 16 chars.
> + *
> + * Return:	'0' on Success; Error code otherwise.
> + */
> +int dprc_set_obj_label(struct fsl_mc_io	*mc_io,
> +		       uint32_t		cmd_flags,
> +		       uint16_t		token,
> +		       char		*obj_type,
> +		       int		obj_id,
> +		       char		*label);

You can fix it in a later patch, but this documentation belongs in the
.c file instead of the .h file.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux